On Tue, May 13, 2008 at 6:37 PM, Hisham <[EMAIL PROTECTED]> wrote:
>
> On Mon, May 12, 2008 at 2:17 AM, Michael Homer <[EMAIL PROTECTED]> wrote:
> >
> > On Mon, May 12, 2008 at 2:15 PM, Hisham <[EMAIL PROTECTED]> wrote:
> > >
> > > On Sun, May 11, 2008 at 5:42 AM, Michael Homer <[EMAIL PROTECTED]>
> wrote:
> > > > On Sun, May 11, 2008 at 8:30 PM, Daniele Maccari <[EMAIL PROTECTED]>
> wrote:
> > > > > 2008/5/11 Michael Homer <[EMAIL PROTECTED]>:
> > > > >> On Sun, May 11, 2008 at 7:29 AM, Daniele Maccari <[EMAIL
> PROTECTED]>
> > > > >> wrote:
> > > > >> > Hi all,
> > > > >> > I was trying to create a recipe for openoffice (source) and I
> ran into
> > > > >> > the
> > > > >> > problem of performing some tasks just in between configure and
> make,
> > > > >> > which
> > > > >> > isn't possible with the current Compile. I then created this
> patch which
> > > > >> > simply run a "post_configure" hook, in the same style as other
> hooks.
> > > > >> > What do you think?
> > > > >> That seems reasonable to me, but you have to update RecipeLint
> as well.
> > > >
> > > > > Oh sure, thanks for the tip. Here come the patches (I renamed the
> Compile
> > > > > one to make it more comprehensible, but it's just the same as the
> previous).
> > > > Thanks - applied r3325.
> > >
> > > Hey, I thought Compile changes that affected the Recipes API would go
> > > through more discussing than that before being applied. The idea of a
> > > post_configure hook has been brought up before in the past and I had
> > > firmly resisted that, on the grounds of avoiding recipe-type-specific
> > > hooks, and that the desire of tweaking things between configure and
> > > make are most often the smell of ugly hacks that typically should done
> > > in other places (such as fixing configure.ac and adding the
> > > declarative rule to rebuild configure, which is way less likely to
> > > break between upstream releases).
> > That's true in general, but OpenOffice has a horrible build process
> > that really does require executing things in between configure and
> > make (configure on its own does hardly anything). You have to run its
> > bootstrap tool to create the build files after configure, and you
> > can't make without them.
>
> Yes, but I don't think making one recipe cleaner outweighs the cons I
> listed above. OpenOffice is a pathological case. The goal of the
> recipes API is not to cover every existing corner case, but to factor
> out common patterns.
It's true that there hasn't been anything else to date that would
(should) use it, so it probably isn't worth maintaining. OpenOffice
will work as a manifest recipe, if it will work at all.
> > The other way would be to turn it into a manifest recipe and run the
> > configure and the rest manually. I think that would be more fragile,
> > rather than less. It may turn out to be necessary to add some wrapper
> > script anyway, since last time I compiled it it required you to
> > actually run the build from tcsh.
> I don't mind making one recipe uglier if it's for the greater good of
> Compile.
But I do think that's overstating the problem.
> Jonas writes:
> > So make OOo recipe_type=makefile and add function calls to pre_make,
> > just like the Qt or Perl recipes do.
>
> I agree. Please revert pre_configure.
Done.
-Michael
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
