On Thu, Oct 16, 2008 at 5:52 PM, David Karell <[EMAIL PROTECTED]> wrote: > Thanks, Lucas. > > Here's another patch (gzipped and uuencoded) that adds more security checks > when parsing > LS_COLORS environment variable. Without it, List will segfault for some > (illegal) values of LS_COLORS > (try setting LS_COLORS="a", you should be able to reproduce the bug).
Hi David, I applied it with a couple of small changes to make it fit with the existing coding style. Also, I removed the extra verification in "if (env && env != default_ls_colors)", as "env" is always ensured to be a reference to a duplicated string (strdup'd). Thanks for the review and for the patch! Lucas -- Alive in the superunknown First it steals your mind And then it steals your soul _______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
