Hi David, I applied it with a couple of small changes to make it fit with the existing coding style. Also, I removed the extra verification in "if (env && env != default_ls_colors)", as "env" is always ensured to be a reference to a duplicated string (strdup'd).
Thanks for the review and for the patch! Lucas Ah, yes, I was a bit uncertain about coding style (especially where to insert spaces in statements etc), thanks! The "env != default_ls_colors" check was just me being paranoid, only never knows what other changes will appear in the future (for instance, failing before env has been strdup:ed, jumping to that cleanup section). But you're right, it's not needed at all right now. Best Regards David -- Be Yourself @ mail.com! Choose From 200+ Email Addresses Get a Free Account at www.mail.com
_______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
