One relatively minor comment below.

However, I'm mainly confused about the use case for this change. Do we
ever check Caja stuff into git? The Caja repo is in SVN and will be for
the foreseeable future....

And why does there have to be a *different* file for when you're using
git? appspot.py does not use SVN or git or any other revision control
system; it just uploads patches.

As I said, I'm confused about the use case. :)


http://codereview.appspot.com/90069/diff/1/2
File tools/appspot.py (right):

http://codereview.appspot.com/90069/diff/1/2#newcode305
Line 305: return path + '.' + re.sub(r'\W', '-', gitbranch)
In other words: If you are using git, the git version overrides? What if
you have both (for some strange reason): why does the git version "win"?

http://codereview.appspot.com/90069

Reply via email to