[Caja] Re: fix 1056, NPE when cajoling , and relax about mandatory attrs</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=google-caja-discuss@googlegroups.com&q=from:%22ihab+.+awad%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">ihab . awad</span></span></a></span> <span class="date"><a href="/search?l=google-caja-discuss@googlegroups.com&q=date:20090707" rel="nofollow">Tue, 07 Jul 2009 22:47:52 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre style="margin: 0em;"> </pre><pre> <a rel="nofollow" href="http://codereview.appspot.com/90071/diff/1/3">http://codereview.appspot.com/90071/diff/1/3</a> File src/com/google/caja/lang/html/html4-attributes-defs.json (right): <a rel="nofollow" href="http://codereview.appspot.com/90071/diff/1/3#newcode510">http://codereview.appspot.com/90071/diff/1/3#newcode510</a> Line 510: "mimeTypes": "image/*", "type": "URI", "optional": true }, When would you use an IMG without a SRC? <a rel="nofollow" href="http://codereview.appspot.com/90071/diff/1/3#newcode558">http://codereview.appspot.com/90071/diff/1/3#newcode558</a> Line 558: "optional": true }, Requiring TYPE for SCRIPT and STYLE seems like generally clean and defensive and standards-based. It will default to "text/javascript" and "text/css" respectively, but leaving them out just seems sloppy and non-future-proof. Is there a real need for making these optional? <a rel="nofollow" href="http://codereview.appspot.com/90071/diff/1/2">http://codereview.appspot.com/90071/diff/1/2</a> File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right): <a rel="nofollow" href="http://codereview.appspot.com/90071/diff/1/2#newcode305">http://codereview.appspot.com/90071/diff/1/2#newcode305</a> Line 305: public void test1056Textarea() throws Exception { Once again, please do not name test cases after bug numbers! This test could be called something like "testNonRequiredAttributesMissing" (if this is not already tested elsewhere in this file, which it might be...). <a rel="nofollow" href="http://codereview.appspot.com/90071">http://codereview.appspot.com/90071</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg04075.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#04076">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#04076">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg04086.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email tSliceCur"><span class="subject">[Caja] Re: fix 1056, NPE when cajoling <textarea>, and r...</span> <span class="sender italic">ihab . awad</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg04086.html">[Caja] Re: fix 1056, NPE when cajoling <textarea>, ...</a></span> <span class="sender italic">felix8a</span></li> <li class="icons-email"><span class="subject"><a href="msg04089.html">[Caja] Re: fix 1056, NPE when cajoling <textarea>, ...</a></span> <span class="sender italic">felix8a</span></li> <li class="icons-email"><span class="subject"><a href="msg04092.html">[Caja] Re: fix 1056, NPE when cajoling <textarea>, ...</a></span> <span class="sender italic">ihab . awad</span></li> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[Caja] Re: fix 1056, NPE when cajoling <textarea>, and relax about mandatory attrs"> <input type="hidden" name="msgid" value="00163616451b773f4e046e2b4741@google.com"> <input type="hidden" name="relpath" value="google-caja-discuss@googlegroups.com/msg04076.html"> <input type="submit" value=" ihab . awad "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="google-caja-discuss@googlegroups.com"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search google-caja-discuss"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/google-caja-discuss@googlegroups.com/">google-caja-discuss - all messages</a></li> <li class="icons-about"><a href="/google-caja-discuss@googlegroups.com/info.html">google-caja-discuss - about the list</a></li> <li class="icons-expand"><a href="/search?l=google-caja-discuss@googlegroups.com&q=subject:%22%5C%5BCaja%5C%5D+Re%5C%3A+fix+1056%2C+NPE+when+cajoling+%3Ctextarea%3E%2C+and+relax+about+mandatory++attrs%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg04075.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg04086.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">00163616451b773f4e046e2b4741@google.com</li> </ul> </div> </body> </html>