LGTM++


http://codereview.appspot.com/89073/diff/5006/6008
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/89073/diff/5006/6008#newcode817
Line 817: }
Peaches and cream.

http://codereview.appspot.com/89073/diff/5006/6008#newcode2039
Line 2039: }
I know this is not within the scope of your immediate changes but, for
consistency, can you please mod the above lines to use unsuffix() as
well?

http://codereview.appspot.com/89073/diff/5006/6009
File src/com/google/caja/plugin/templates/TemplateCompiler.java (right):

http://codereview.appspot.com/89073/diff/5006/6009#newcode317
Line 317: if (!checkIllegalSuffix(value, pos)) { return; }
Didn't you mean checkIllegalSuffix*es*(...)?

http://codereview.appspot.com/89073/diff/5006/6007
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java
(right):

http://codereview.appspot.com/89073/diff/5006/6007#newcode435
Line 435: //     new Block());
How about just checking for an AssertionFailure exception from
assertSafeHtml or something? In other words, given that there's a TODO
here anyway, it's better to have *a* test using a blunt instrument than
comment out the test entirely?

http://codereview.appspot.com/89073

Reply via email to