Reviewers: google-caja-discuss_googlegroups.com, metaweta, DavidSarah,
Message:
Thanks much!
http://codereview.appspot.com/109074/diff/52/70
File src/com/google/caja/cajita-debugmode.js (left):
http://codereview.appspot.com/109074/diff/52/70#oldcode242
Line 242: // Make sure that tamed Errors propogate the cajitaStack___,
On 2009/08/24 18:58:47, DavidSarah wrote:
sp: 'propagate'
Done.
http://codereview.appspot.com/109074/diff/52/70
File src/com/google/caja/cajita-debugmode.js (right):
http://codereview.appspot.com/109074/diff/52/70#newcode238
Line 238: // TODO(erights): What does the following comment mean?
On 2009/08/24 18:58:47, DavidSarah wrote:
I think the comment is trying to explain why the "&&
!ex.cajitaStack___" is
necessary. That is, if we clobbered an existing ex.cajitaStack___ with
the stack
at the point of the tameException, we would lose useful (sealed)
information
about the original exception in the case of a rethrow.
(But it took me 3 minutes to work out that the comment was referring
to just the
"&& !ex.cajitaStack___", so it definitely isn't clear.)
Done.
http://codereview.appspot.com/109074/diff/52/73
File src/com/google/caja/demos/applet/index.html (left):
http://codereview.appspot.com/109074/diff/52/73#oldcode172
Line 172: </applet>
On 2009/08/24 18:58:47, DavidSarah wrote:
"<!-- see
http://java.sun.com/javase/6/webnotes/6u10/plugin2/index.html for
documentation of classloader_cache and separate_jvm parameters -->"
Done.
http://codereview.appspot.com/109074/diff/52/65
File src/com/google/caja/parser/js/Parser.java (right):
http://codereview.appspot.com/109074/diff/52/65#newcode570
Line 570: // restricted production. See the grammar above and ES3
S7.9.1
On 2009/08/24 18:58:47, DavidSarah wrote:
"and ES3 or ES5 S7.9.1"
Done.
http://codereview.appspot.com/109074/diff/52/65#newcode782
Line 782: // "restricted productions" according to ES3 S7.9.1.
On 2009/08/24 18:58:47, DavidSarah wrote:
"ES3 or ES5 S7.9.1"
Done.
http://codereview.appspot.com/109074/diff/52/66
File src/com/google/caja/parser/js/UseSubsetDirective.java (right):
http://codereview.appspot.com/109074/diff/52/66#newcode32
Line 32: * "Use subsets" are defined in ES5.
On 2009/08/24 18:58:47, DavidSarah wrote:
Add "TODO: grammar no longer specifies a list of subsets."
Is there an issue for this?
Done.
http://codereview.appspot.com/109074/diff/52/67
File src/com/google/caja/parser/js/WithStmt.java (left):
http://codereview.appspot.com/109074/diff/52/67#oldcode28
Line 28: * chain.
On 2009/08/24 18:58:47, DavidSarah wrote:
"(ES5 expresses this in terms of environment records but with similar
effect.)"
Done.
http://codereview.appspot.com/109074/diff/52/63
File src/com/google/caja/parser/quasiliteral/CajitaRewriter.java
(right):
http://codereview.appspot.com/109074/diff/52/63#newcode330
Line 330: // in FF3, and ES5 is specifying the behavior of [] and {} in
terms
On 2009/08/24 18:58:47, DavidSarah wrote:
"and ES5 specifies"
Done.
http://codereview.appspot.com/109074/diff/52/60
File src/com/google/caja/render/BufferingRenderer.java (left):
http://codereview.appspot.com/109074/diff/52/60#oldcode68
Line 68: // of semicolon insertion.
On 2009/08/24 18:58:47, DavidSarah wrote:
"... since ES3 and ES5 say ..."
"This is inconsistently implemented, but the rewriting works
regardless of
whether an implementation actually treats the comment as a newline for
semicolon
insertion."
Done.
http://codereview.appspot.com/109074/diff/52/59
File src/com/google/caja/render/JsRenderUtil.java (right):
http://codereview.appspot.com/109074/diff/52/59#newcode32
Line 32: // According to semicolon insertion rules in ES3 Section 7.9.1
On 2009/08/24 18:58:47, DavidSarah wrote:
"ES3 and ES5" (the rules have not changed)
Done.
Description:
Addresses issues 1038, 1044, 1086, 1097, 1098, 1099, 1100.
Please see these issues themselves for documentation.
Some significant performance improvements on time to create a function
(testFunctionClosure in both Cajita and Valija).
callStackUnsealer now returns other disagnostic info which has been
observed on thrown Errors on some browsers.
Date.prototype.toJSON is now whitelisted.
Trademark API is now much more expressive (and more E-like).
Incorporated David-Sarah's suggestion for making the applet
classloader caching less sticky. Helps a lot!
Changed obsolete references to "ES3.1" to "ES5".
Please review this at http://codereview.appspot.com/109074
Affected files:
M src/com/google/caja/cajita-debugmode.js
M src/com/google/caja/cajita.js
M src/com/google/caja/demos/applet/index.html
M src/com/google/caja/demos/applet/testbed.js
M src/com/google/caja/demos/calendar/demo-cajoled.html
M src/com/google/caja/domita/package.html
M src/com/google/caja/parser/ParserBase.java
M src/com/google/caja/parser/js/Parser.java
M src/com/google/caja/parser/js/UseSubsetDirective.java
M src/com/google/caja/parser/js/WithStmt.java
M src/com/google/caja/parser/quasiliteral/CajitaRewriter.java
M src/com/google/caja/parser/quasiliteral/DefaultValijaRewriter.java
M src/com/google/caja/parser/quasiliteral/PermitTemplate.java
M src/com/google/caja/plugin/domita.js
M src/com/google/caja/plugin/stages/CajaRuntimeDebuggingRewriter.java
M src/com/google/caja/render/BufferingRenderer.java
M src/com/google/caja/render/JsRenderUtil.java
M src/com/google/caja/valija-cajita.js
M tests/com/google/caja/opensocial/example-rewritten.xml
M tests/com/google/caja/parser/js/ParserTest.java
M tests/com/google/caja/parser/quasiliteral/CajitaRewriterTest.java
M
tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java
M
tests/com/google/caja/parser/quasiliteral/DefaultValijaRewriterTest.java
M tests/com/google/caja/plugin/stages/DebuggingSymbolsStageTest.java
M third_party/js/json_sans_eval/json_sans_eval.js
