http://codereview.appspot.com/109074/diff/52/70 File src/com/google/caja/cajita-debugmode.js (right): http://codereview.appspot.com/109074/diff/52/70#newcode88 Line 88: * Returns a call stack, that will not be mutated by subsequent remove comma http://codereview.appspot.com/109074/diff/52/70#newcode242 Line 242: // > doesn't make ex unavailable to code with access to the unsealer. Is this comment related to issue1110? http://codereview.appspot.com/109074/diff/52/71 File src/com/google/caja/cajita.js (right): http://codereview.appspot.com/109074/diff/52/71#newcode790 Line 790: fail('cajita.freeze(obj) applies only to JSON Containers: ', (and functions and Errors) http://codereview.appspot.com/109074/diff/52/71#newcode1437 Line 1437: throw new TypeError("Can't read " + name + ' on ' + obj); Double quotes http://codereview.appspot.com/109074/diff/52/71#newcode1735 Line 1735: throw new TypeError("Can't call " + name + ' on ' + obj); Double quotes http://codereview.appspot.com/109074/diff/52/71#newcode1864 Line 1864: throw new TypeError("Can't delete " + name + ' on ' + obj); Double quotes http://codereview.appspot.com/109074/diff/52/71#newcode2844 Line 2844: * ejection. If these to their own non-local exit, that takes If these *do* their own http://codereview.appspot.com/109074/diff/52/71#newcode2887 Line 2887: * If <tt>opt_ejector</tt> is omitted, falsy, disabled, or returns Can't omit the first argument. http://codereview.appspot.com/109074/diff/52/71#newcode3004 Line 3004: // partial stamping. Add one line here: Assumes single-threaded execution and non-mutating accessors. http://codereview.appspot.com/109074/diff/52/71#newcode3402 Line 3402: case 'object': case 'function': boolean? http://codereview.appspot.com/109074/diff/52/65 File src/com/google/caja/parser/js/Parser.java (right): http://codereview.appspot.com/109074/diff/52/65#newcode570 Line 570: // restricted production. See the grammar above and ES3 S7.9.1 On 2009/08/25 00:12:38, MarkM wrote:
On 2009/08/24 18:58:47, DavidSarah wrote: > "and ES3 or ES5 S7.9.1"
Done.
Did you intend not to mention ES5 here and below? http://codereview.appspot.com/109074/diff/52/67 File src/com/google/caja/parser/js/WithStmt.java (left): http://codereview.appspot.com/109074/diff/52/67#oldcode28 Line 28: * chain. On 2009/08/25 00:12:38, MarkM wrote:
On 2009/08/24 18:58:47, DavidSarah wrote: > "(ES5 expresses this in terms of environment records but with
similar
effect.)"
Done.
No mention of ES5 here? http://codereview.appspot.com/109074/diff/52/67 File src/com/google/caja/parser/js/WithStmt.java (right): http://codereview.appspot.com/109074/diff/52/67#newcode28 Line 28: * chain. Still no mention of ES5? http://codereview.appspot.com/109074/diff/52/54 File tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java (right): http://codereview.appspot.com/109074/diff/52/54#newcode420 Line 420: // should be figured out first. Please add a new issue for this if you're going to close 1086. http://codereview.appspot.com/109074
