[email protected] wrote: > http://codereview.appspot.com/110096/diff/4003/4012#newcode64 > Line 64: public boolean isSafeIdentifier(String ident) { > On 2009/09/15 18:31:58, DavidSarah wrote: >> Is this duplicating checks elsewhere in the cajoler? > > There are checks that identifiers are valid. > But this is necessary because otherwise, AlphaRenaming might take in > code that passes those checks and produce code that fails them.
Right, but I meant that there is a maintenance and security review issue with having these checks in multiple places. -- David-Sarah Hopwood ⚥ http://davidsarah.livejournal.com
