http://codereview.appspot.com/110096/diff/4003/4012 File src/com/google/caja/util/SafeIdentifierMaker.java (right): http://codereview.appspot.com/110096/diff/4003/4012#newcode64 Line 64: public boolean isSafeIdentifier(String ident) { David-Sarah responded:
Right, but I meant that there is a maintenance and security review issue with having these checks in multiple places.
Ok. So you're arguing for code consolidation. I'll poke around and see if I can find a way to consolidate, location-wise at least, the various identifier predicates. http://codereview.appspot.com/110096
