LGTM


http://codereview.appspot.com/130086/diff/7001/7012
File src/com/google/caja/ancillary/opt/ParseTreeKB.java (right):

http://codereview.appspot.com/130086/diff/7001/7012#newcode52
Line 52: public class ParseTreeKB {
Does KB stand for "knowledge base"?

http://codereview.appspot.com/130086/diff/7001/7006
File src/com/google/caja/parser/quasiliteral/Scope.java (right):

http://codereview.appspot.com/130086/diff/7001/7006#newcode467
Line 467: * @return whether 'name' is defined as a declared function
within this
You seem to be talking about four different cases:

1) local var: var name = value;
2) formal parameter: function (name) { ... }
3) declared function: function name() { ... }
4) undefined

What does this method distinguish between?  (any of 1-3) vs 4?

http://codereview.appspot.com/130086

Reply via email to