Reviewers: metaweta,
http://codereview.appspot.com/130086/diff/7001/7012
File src/com/google/caja/ancillary/opt/ParseTreeKB.java (right):
http://codereview.appspot.com/130086/diff/7001/7012#newcode52
Line 52: public class ParseTreeKB {
On 2009/10/26 23:20:11, metaweta wrote:
Does KB stand for "knowledge base"?
yes. And kibbles & bits.
http://codereview.appspot.com/130086/diff/7001/7006
File src/com/google/caja/parser/quasiliteral/Scope.java (right):
http://codereview.appspot.com/130086/diff/7001/7006#newcode467
Line 467: * @return whether 'name' is defined as a declared function
within this
On 2009/10/26 23:20:11, metaweta wrote:
You seem to be talking about four different cases:
1) local var: var name = value;
2) formal parameter: function (name) { ... }
3) declared function: function name() { ... }
4) undefined
What does this method distinguish between? (any of 1-3) vs 4?
LocalType does not distinguish between 1 and 2.
(3) would be LocalType.FUNCTION_DECLARED.
(4) would be a null LocalType.
Description:
A code minifier that can eliminate code that is not reached on a
particular user agent.
Most of this code is in ancillary. Please review the non ancillary
bits.
See http://code.google.com/p/google-caja/wiki/UserAgentContext
Please review this at http://codereview.appspot.com/130086
Affected files:
M build.xml
A src/com/google/caja/ancillary/opt/ConstLocalOptimization.java
A src/com/google/caja/ancillary/opt/EnvironmentData.java
A src/com/google/caja/ancillary/opt/EnvironmentDatum.java
A src/com/google/caja/ancillary/opt/Fact.java
A src/com/google/caja/ancillary/opt/Firefox-3.0.12.env.json
A src/com/google/caja/ancillary/opt/Firefox-3.0.5.env.json
A src/com/google/caja/ancillary/opt/Firefox-3.5.3.env.json
A src/com/google/caja/ancillary/opt/LocalVarRenamer.java
A src/com/google/caja/ancillary/opt/MSIE-6.0.env.json
A src/com/google/caja/ancillary/opt/ParseTreeKB.java
A src/com/google/caja/ancillary/opt/Safari-531.9.env.json
A src/com/google/caja/ancillary/opt/ScopeInfo.java
A src/com/google/caja/ancillary/opt/Use.java
A src/com/google/caja/ancillary/opt/environment-checks.html
A src/com/google/caja/ancillary/opt/environment-checks.js
A src/com/google/caja/ancillary/opt/package.html
A src/com/google/caja/ancillary/opt/table.py
M src/com/google/caja/parser/quasiliteral/Scope.java
M src/com/google/caja/plugin/BuildServiceImplementation.java
M src/com/google/caja/tools/TransformAntTask.java
A tests/com/google/caja/ancillary/opt/ConstLocalOptimizationTest.java
A tests/com/google/caja/ancillary/opt/EnvironmentChecksTest.java
A tests/com/google/caja/ancillary/opt/LocalVarRenamerTest.java
A tests/com/google/caja/ancillary/opt/ParseTreeKBTest.java
M third_party/js/json_sans_eval/json_sans_eval.js
