Snapshotted.
http://codereview.appspot.com/136053/diff/1/38 File build.xml (right): http://codereview.appspot.com/136053/diff/1/38#newcode777 Line 777: language="cajita"/> On 2009/10/22 01:48:51, DavidSarah wrote:
language="caja"
Done. http://codereview.appspot.com/136053/diff/1/38#newcode783 Line 783: <output file="${www}/lolcat-search/kittens.co.html" language="cajita"/> On 2009/10/22 01:48:51, DavidSarah wrote:
language="caja"
Done. http://codereview.appspot.com/136053/diff/1/38#newcode840 Line 840: language="cajita"/> On 2009/10/22 01:48:51, DavidSarah wrote:
language="caja"
Done. http://codereview.appspot.com/136053/diff/1/38#newcode846 Line 846: <output file="${www}/slides/kittens.co.html" language="cajita"/> On 2009/10/22 01:48:51, DavidSarah wrote:
language="caja"
Done. http://codereview.appspot.com/136053/diff/1/23 File src/com/google/caja/commonjs-sandbox.js (right): http://codereview.appspot.com/136053/diff/1/23#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/26 File src/com/google/caja/plugin/PluginMeta.java (right): http://codereview.appspot.com/136053/diff/1/26#newcode28 Line 28: private boolean valijaMode; On 2009/10/22 01:48:51, DavidSarah wrote:
now unused; delete this field
Done. http://codereview.appspot.com/136053/diff/1/37 File src/com/google/caja/valija-cajita.js (right): http://codereview.appspot.com/136053/diff/1/37#newcode56 Line 56: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/5 File tests/com/google/caja/a.js (right): http://codereview.appspot.com/136053/diff/1/5#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/11 File tests/com/google/caja/c.js (right): http://codereview.appspot.com/136053/diff/1/11#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/19 File tests/com/google/caja/demos/applet/CajaAppletTest.java (left): http://codereview.appspot.com/136053/diff/1/19#oldcode62 Line 62: TestUtil.readResource(getClass(), "caja-applet-cajita-golden.js"), On 2009/10/22 01:48:51, DavidSarah wrote:
On 2009/10/22 00:50:28, MikeSamuel wrote: > Rather than throwing out a useful test, can you run it twice, once
with "use
> cajita" at the top.
Or once with "use strict"; "use cajita"; at the top.
See reply to Mike. http://codereview.appspot.com/136053/diff/1/19#oldcode62 Line 62: TestUtil.readResource(getClass(), "caja-applet-cajita-golden.js"), On 2009/10/22 00:50:28, MikeSamuel wrote:
Rather than throwing out a useful test, can you run it twice, once
with "use
cajita" at the top.
Per our conversation: the applet is now no longer passing through any "cajita/valija" signal; it just calls the generic cajoler. So it's just adequate to test the valija case, knowing that the Valija rewriter will fall back to Cajita if it sees the proper use subset directives. http://codereview.appspot.com/136053/diff/1/20 File tests/com/google/caja/demos/benchmarks/BenchmarkRunner.java (right): http://codereview.appspot.com/136053/diff/1/20#newcode185 Line 185: + " 'require cajita';" On 2009/10/22 00:50:28, MikeSamuel wrote:
What is 'require strict' supposed to do?
And I claim not to be a Perl programmer. :) http://codereview.appspot.com/136053/diff/1/20#newcode185 Line 185: + " 'require cajita';" On 2009/10/22 01:48:51, DavidSarah wrote:
On 2009/10/22 00:50:28, MikeSamuel wrote: > What is 'require strict' supposed to do?
This should be 'use strict'; 'use cajita';
Done. http://codereview.appspot.com/136053/diff/1/21 File tests/com/google/caja/demos/benchmarks/BenchmarkSize.java (right): http://codereview.appspot.com/136053/diff/1/21#newcode200 Line 200: + " 'require cajita';" On 2009/10/22 01:48:51, DavidSarah wrote:
On 2009/10/22 00:50:28, MikeSamuel wrote: > ditto
should be 'use strict'; 'use cajita';
Done. http://codereview.appspot.com/136053/diff/1/21#newcode200 Line 200: + " 'require cajita';" On 2009/10/22 00:50:28, MikeSamuel wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/3 File tests/com/google/caja/foo/b.js (right): http://codereview.appspot.com/136053/diff/1/3#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/2 File tests/com/google/caja/foo/f.js (right): http://codereview.appspot.com/136053/diff/1/2#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/6 File tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java (right): http://codereview.appspot.com/136053/diff/1/6#newcode102 Line 102: assertRewritePasses("SocialHelloWorld.xml", MessageLevel.WARNING); On 2009/10/22 00:50:28, MikeSamuel wrote:
So this no longer tests it in Cajita mode?
Correct, based on the premise that gadgets are HTML, and HTML is henceforth always Valija at the top level. (Specific <script>s or functions can, of course, opt into Cajita.) http://codereview.appspot.com/136053/diff/1/10 File tests/com/google/caja/parser/quasiliteral/c.js (right): http://codereview.appspot.com/136053/diff/1/10#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/9 File tests/com/google/caja/parser/quasiliteral/foo/b.js (right): http://codereview.appspot.com/136053/diff/1/9#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/8 File tests/com/google/caja/parser/quasiliteral/foo/testPrimordials.js (right): http://codereview.appspot.com/136053/diff/1/8#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053/diff/1/17 File tests/com/google/caja/plugin/ExpressionSanitizerTest.java (right): http://codereview.appspot.com/136053/diff/1/17#newcode51 Line 51: " 'use cajita';" On 2009/10/22 01:48:51, DavidSarah wrote:
" 'use strict'; 'use cajita';"
Done. http://codereview.appspot.com/136053/diff/1/13 File tests/com/google/caja/plugin/HtmlCompiledPluginTest.java (right): http://codereview.appspot.com/136053/diff/1/13#newcode133 Line 133: + " 'use strict, cajita';" On 2009/10/22 01:48:51, DavidSarah wrote:
Bad syntax; see issue #1111. Should be 'use strict'; 'use cajita';
Done. http://codereview.appspot.com/136053/diff/1/13#newcode145 Line 145: + " (function () { 'use strict,cajita'; return {}.hello; })()," On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/13#newcode146 Line 146: + " (function f() { 'use strict,cajita'; return {}.hello; })() ]" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/13#newcode152 Line 152: + " function f() { 'use strict,cajita'; return {}.hello; }" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/13#newcode168 Line 168: " 'use strict, cajita';\n" + On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/13#newcode178 Line 178: "<script>'use strict, cajita';throw new Error('panic');a=1;</script>" + On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/13#newcode180 Line 180: " 'use strict, cajita';\n" + On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/13#newcode184 Line 184: " 'use strict, cajita';\n" + On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/12 File tests/com/google/caja/plugin/domita_test.html (right): http://codereview.appspot.com/136053/diff/1/12#newcode211 Line 211: loadScript('valija.co.js'); On 2009/10/22 00:50:28, MikeSamuel wrote:
Why are we loading valija.co.js even when it's not valija?
Because, even though the tests themselves are in a 'use cajita' block, the enclosing HTML is, at the top level, always Valija. And that guff looks for $v and what not, and fails if it's not there. The previous way we did this test -- by cajoling HTML as Cajita all the way -- was a special case that we achieved through our build rules; it was not a sort of cajoling we expected any Caja users to actually attempt. http://codereview.appspot.com/136053/diff/1/16 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/136053/diff/1/16#newcode463 Line 463: /*@@cajaLanguageSelectionStatements@@*/ On 2009/10/22 00:50:28, MikeSamuel wrote:
Ok. Maybe a pointer to the code that does the substitution.
Done. http://codereview.appspot.com/136053/diff/1/14 File tests/com/google/caja/plugin/stages/DebuggingSymbolsStageTest.java (right): http://codereview.appspot.com/136053/diff/1/14#newcode37 Line 37: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
"'use strict'; 'use cajita';\n"
Done. http://codereview.appspot.com/136053/diff/1/14#newcode47 Line 47: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode65 Line 65: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode84 Line 84: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode89 Line 89: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode97 Line 97: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode111 Line 111: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode119 Line 119: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode128 Line 128: + "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode138 Line 138: + "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode149 Line 149: + "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode169 Line 169: + "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode184 Line 184: + "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode197 Line 197: "'use strict, cajita';\n" On 2009/10/22 01:48:51, DavidSarah wrote:
ditto
Done. http://codereview.appspot.com/136053/diff/1/14#newcode283 Line 283: " 'use strict, cajita';" On 2009/10/22 01:48:51, DavidSarah wrote:
"'use strict'; 'use cajita';"
Done. http://codereview.appspot.com/136053/diff/1/4 File tests/com/google/caja/recursion.js (right): http://codereview.appspot.com/136053/diff/1/4#newcode14 Line 14: On 2009/10/22 01:48:51, DavidSarah wrote:
"use strict";
Done. http://codereview.appspot.com/136053
