http://codereview.appspot.com/136053/diff/1/12 File tests/com/google/caja/plugin/domita_test.html (right): http://codereview.appspot.com/136053/diff/1/12#newcode211 tests/com/google/caja/plugin/domita_test.html:211: loadScript('valija.co.js'); On 2009/10/30 06:17:42, ihab.awad wrote:
On 2009/10/22 00:50:28, MikeSamuel wrote: > Why are we loading valija.co.js even when it's not valija?
Because, even though the tests themselves are in a 'use cajita' block,
the
enclosing HTML is, at the top level, always Valija. And that guff
looks for $v
and what not, and fails if it's not there.
The previous way we did this test -- by cajoling HTML as Cajita all
the way --
was a special case that we achieved through our build rules; it was
not a sort
of cajoling we expected any Caja users to actually attempt.
But shouldn't we test under cajita mode as a container probably would -- without loading the unnecessary valija stuff? http://codereview.appspot.com/136053/diff/7001/7020 File tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java (right): http://codereview.appspot.com/136053/diff/7001/7020#newcode99 tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java:99: } How is this test different from testSocialHelloWorld on line 101 now? http://codereview.appspot.com/136053/diff/7001/7023 File tests/com/google/caja/plugin/domita_test.html (right): http://codereview.appspot.com/136053/diff/7001/7023#newcode315 tests/com/google/caja/plugin/domita_test.html:315: // TODO(mikesamuel): rewrite XHR and setTimeout tests to use this scheme. plz wrap or maybe deindent this entire script block body http://codereview.appspot.com/136053/diff/7001/7023#newcode377 tests/com/google/caja/plugin/domita_test.html:377: 'assert', 'assertContains', 'assertEquals', 'assertEvaluatesToFalse', plz wrap http://codereview.appspot.com/136053/diff/7001/7023#newcode438 tests/com/google/caja/plugin/domita_test.html:438: return 'http://gadget-proxy/?url=' + encodeURIComponent(uri) plz wrap http://codereview.appspot.com/136053/diff/7001/7023#newcode448 tests/com/google/caja/plugin/domita_test.html:448: // Create a readonly mirror of document so that we can test that mutations plz wrap http://codereview.appspot.com/136053/diff/7001/7026 File tests/com/google/caja/plugin/jsunit.js (right): http://codereview.appspot.com/136053/diff/7001/7026#newcode57 tests/com/google/caja/plugin/jsunit.js:57: console.log('TEST ERROR: pass without a test ID'); Maybe console.error instead of console.log http://codereview.appspot.com/136053
