Snapshot.
Also replaced assertion errors.
http://codereview.appspot.com/129056/diff/2001/3046
File src/com/google/caja/SomethingWidgyHappenedError.java (right):
http://codereview.appspot.com/129056/diff/2001/3046#newcode19
src/com/google/caja/SomethingWidgyHappenedError.java:19: /**
On 2009/11/11 20:49:01, MikeSamuel wrote:
Plz add blank line after imports.
Done.
http://codereview.appspot.com/129056/diff/2001/3048
File src/com/google/caja/demos/applet/CajaApplet.java (right):
http://codereview.appspot.com/129056/diff/2001/3048#newcode129
src/com/google/caja/demos/applet/CajaApplet.java:129: throw new
SomethingWidgyHappenedError("UTF-8 should be supported",
On 2009/11/11 20:49:01, MikeSamuel wrote:
Plz split the line after (
The ways of formatting from the C++ guidelines are
foobar(baz,
boo);
or break after ( and indent by 4
foobar(
baz, boo);
Done.
http://codereview.appspot.com/129056/diff/2001/3017
File src/com/google/caja/lexer/escaping/Escaping.java (right):
http://codereview.appspot.com/129056/diff/2001/3017#newcode166
src/com/google/caja/lexer/escaping/Escaping.java:166: "StringBuilders
don't throw IOException");
On 2009/11/11 20:49:01, MikeSamuel wrote:
indent
Done.
http://codereview.appspot.com/129056/diff/2001/3017#newcode194
src/com/google/caja/lexer/escaping/Escaping.java:194: "StringBuilders
don't throw IOException");
On 2009/11/11 20:49:01, MikeSamuel wrote:
ditto
Done.
http://codereview.appspot.com/129056/diff/2001/3017#newcode532
src/com/google/caja/lexer/escaping/Escaping.java:532: "StringBuilders
don't throw IOException");
On 2009/11/11 20:49:01, MikeSamuel wrote:
ditto
Done.
http://codereview.appspot.com/129056/diff/2001/3042
File src/com/google/caja/plugin/templates/Localizer.java (right):
http://codereview.appspot.com/129056/diff/2001/3042#newcode228
src/com/google/caja/plugin/templates/Localizer.java:228: "IOException
reading from String");
On 2009/11/11 20:49:01, MikeSamuel wrote:
Add ex as cause plz.
Done.
http://codereview.appspot.com/129056/diff/2001/3002
File tests/com/google/caja/lexer/JsLexerTest.java (right):
http://codereview.appspot.com/129056/diff/2001/3002#newcode18
tests/com/google/caja/lexer/JsLexerTest.java:18: import
com.google.caja.util.TestUtil;
On 2009/11/11 20:49:01, MikeSamuel wrote:
unnecessary imports
Done.
http://codereview.appspot.com/129056/diff/2001/3010
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java
(right):
http://codereview.appspot.com/129056/diff/2001/3010#newcode66
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:66:
MessagePart.Factory.valueOf(
On 2009/11/11 20:49:01, MikeSamuel wrote:
indent
Done.
http://codereview.appspot.com/129056/diff/2001/3010#newcode357
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:357:
MessagePart.Factory.valueOf(
On 2009/11/11 20:49:01, MikeSamuel wrote:
ditto
Done.
http://codereview.appspot.com/129056/diff/2001/3015
File tests/com/google/caja/util/CajaTestCase.java (right):
http://codereview.appspot.com/129056/diff/2001/3015#newcode260
tests/com/google/caja/util/CajaTestCase.java:260: throw new
SomethingWidgyHappenedError("IOException from StringBuilder");
On 2009/11/11 20:49:01, MikeSamuel wrote:
Please thread ex through.
Done.
http://codereview.appspot.com/129056
