Snapshot.

http://codereview.appspot.com/129056/diff/6054/7020
File src/com/google/caja/lexer/escaping/Escaping.java (right):

http://codereview.appspot.com/129056/diff/6054/7020#newcode92
src/com/google/caja/lexer/escaping/Escaping.java:92: "StringBuilders
don't throw IOException");
On 2009/12/03 01:57:40, MikeSamuel wrote:
, ex

Done. Ditto below.

http://codereview.appspot.com/129056/diff/6054/7035
File src/com/google/caja/parser/Normalizer.java (right):

http://codereview.appspot.com/129056/diff/6054/7035#newcode78
src/com/google/caja/parser/Normalizer.java:78: "Normalizer unexpectedly
uninvokable", (RuntimeException) th);
On 2009/12/03 01:57:40, MikeSamuel wrote:
Can't we just propagate th up here and in the else clause?
If not, we don't need to branch.

Done.

http://codereview.appspot.com/129056/diff/6054/7064
File src/com/google/caja/reporting/Message.java (right):

http://codereview.appspot.com/129056/diff/6054/7064#newcode82
src/com/google/caja/reporting/Message.java:82: throw e;
On 2009/12/03 01:57:40, MikeSamuel wrote:
These three lines can be condensed to 1.

Done.

http://codereview.appspot.com/129056

Reply via email to