http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js
File src/com/google/caja/es53.js (right):

http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode47
src/com/google/caja/es53.js:47: Object.prototype.hasOwnProperty___ =
Object.prototype.hasOwnProperty;
I think the reversion from virtualize should happen as a separate
change, since it applies to so much of the file.

http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode177
src/com/google/caja/es53.js:177: var edIndex = aguments[2];
Bug in my code: edIndex should be endIndex

http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode751
src/com/google/caja/es53.js:751: // Is there any reason even to log
these? They are many, and
There shouldn't be any; where are you seeing them?  I was getting errors
due to accidentally taming something in two ways, so I put this in.

http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode921
src/com/google/caja/es53.js:921: // ES-Harmony proposal
Include a link to the proposal

http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode1443
src/com/google/caja/es53.js:1443: proxy['ne___'] = false,
Here and below, use . instead of ['...']

http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode1459
src/com/google/caja/es53.js:1459: if (typeof trap === 'function') {
What about regexps?

http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode1611
src/com/google/caja/es53.js:1611: proxy[p] = v;
Did you mean to return here?

http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode3155
src/com/google/caja/es53.js:3155: var P = names[i];
yikes!  good catch

http://codereview.appspot.com/2225043/

Reply via email to