http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right):
http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode47 src/com/google/caja/es53.js:47: Object.prototype.hasOwnProperty___ = Object.prototype.hasOwnProperty; On 2010/09/23 20:56:02, metaweta wrote:
I think the reversion from virtualize should happen as a separate
change, since
it applies to so much of the file.
Done. http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode177 src/com/google/caja/es53.js:177: var edIndex = aguments[2]; On 2010/09/23 20:56:02, metaweta wrote:
Bug in my code: edIndex should be endIndex
And aguments should be arguments. On the same line and we both missed it! Done. http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode751 src/com/google/caja/es53.js:751: // Is there any reason even to log these? They are many, and On 2010/09/23 20:56:02, metaweta wrote:
There shouldn't be any; where are you seeing them? I was getting
errors due to
accidentally taming something in two ways, so I put this in.
I don't remember. I'll instrument and re-run until I reproduce this. Or I'll revert. http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode921 src/com/google/caja/es53.js:921: // ES-Harmony proposal On 2010/09/23 20:56:02, metaweta wrote:
Include a link to the proposal
Done. http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode1443 src/com/google/caja/es53.js:1443: proxy['ne___'] = false, On 2010/09/23 20:56:02, metaweta wrote:
Here and below, use . instead of ['...']
Weird. I don't know why I did it that way. Done. http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode1459 src/com/google/caja/es53.js:1459: if (typeof trap === 'function') { On 2010/09/23 20:56:02, metaweta wrote:
What about regexps?
Added a TODO. Will get back to this. I think Tom's right -- the fundamental traps should error instead of defaulting. http://codereview.appspot.com/2225043/diff/10001/src/com/google/caja/es53.js#newcode1611 src/com/google/caja/es53.js:1611: proxy[p] = v; On 2010/09/23 20:56:02, metaweta wrote:
Did you mean to return here?
I did indeed. Done. http://codereview.appspot.com/2225043/
