http://codereview.appspot.com/2206045/diff/3001/build.xml File build.xml (right):
http://codereview.appspot.com/2206045/diff/3001/build.xml#newcode607 build.xml:607: <!-- Copy the test files to make them available for the script module This makes demos depend on tests? http://codereview.appspot.com/2206045/diff/3001/src/com/google/caja/cajita-module.js File src/com/google/caja/cajita-module.js (right): http://codereview.appspot.com/2206045/diff/3001/src/com/google/caja/cajita-module.js#newcode193 src/com/google/caja/cajita-module.js:193: var jsonpCallbackCount = 0; Please move this closer to the single place of use. http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/plugin/uri.js File src/com/google/caja/plugin/uri.js (right): http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/plugin/uri.js#newcode381 src/com/google/caja/plugin/uri.js:381: newPort = Number(newPort); Indentation is wonky. For my info, curious what threat you were concerned about here. Does the next line not subsume the cast to number? http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/service/CajolingService.java File src/com/google/caja/service/CajolingService.java (right): http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/service/CajolingService.java#newcode198 src/com/google/caja/service/CajolingService.java:198: System.err.println(render(mq)); Please don't print to stdout/err in services. http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/service/InnocentHandler.java File src/com/google/caja/service/InnocentHandler.java (left): http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/service/InnocentHandler.java#oldcode1 src/com/google/caja/service/InnocentHandler.java:1: // Copyright 2008 Google Inc. All Rights Reserved. Ah sadness. This change does eliminate a useful service - previously a host page that loaded scripts via a script src tag could use the cajoling service to innocentify scripts by proxying. Is there any reason the innocent code transformer cannot be supported via jsonp? http://codereview.appspot.com/2206045/diff/1039/tests/com/google/caja/plugin/DomitaTest.java File tests/com/google/caja/plugin/DomitaTest.java (right): http://codereview.appspot.com/2206045/diff/1039/tests/com/google/caja/plugin/DomitaTest.java#newcode71 tests/com/google/caja/plugin/DomitaTest.java:71: poll(20000, 1000, new Check() { :( http://codereview.appspot.com/2206045/
