http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/plugin/uri.js File src/com/google/caja/plugin/uri.js (right):
http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/plugin/uri.js#newcode381 src/com/google/caja/plugin/uri.js:381: newPort = Number(newPort); On 2010/09/29 06:20:02, jasvir wrote:
Indentation is wonky.
Fixed.
For my info, curious what threat you were concerned about here. Does the next line not subsume the cast to number?
Well ... it _does_ fail safe. :P The problem is that 'newPort' is idiomatically a string. (newPort & ...) is a number. Even in the success case, they are _always_ !== to each other. http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/service/CajolingService.java File src/com/google/caja/service/CajolingService.java (right): http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/service/CajolingService.java#newcode198 src/com/google/caja/service/CajolingService.java:198: System.err.println(render(mq)); On 2010/09/29 06:20:02, jasvir wrote:
Please don't print to stdout/err in services.
That was debug cruft. Bobbitted. http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/service/InnocentHandler.java File src/com/google/caja/service/InnocentHandler.java (left): http://codereview.appspot.com/2206045/diff/1039/src/com/google/caja/service/InnocentHandler.java#oldcode1 src/com/google/caja/service/InnocentHandler.java:1: // Copyright 2008 Google Inc. All Rights Reserved. On 2010/09/29 06:20:02, jasvir wrote:
Ah sadness. This change does eliminate a useful service - previously
a host
page that loaded scripts via a script src tag could use the cajoling
service to
innocentify scripts by proxying. Is there any reason the innocent
code
transformer cannot be supported via jsonp?
Ok, reinstating. http://codereview.appspot.com/2206045/diff/1039/tests/com/google/caja/plugin/DomitaTest.java File tests/com/google/caja/plugin/DomitaTest.java (right): http://codereview.appspot.com/2206045/diff/1039/tests/com/google/caja/plugin/DomitaTest.java#newcode71 tests/com/google/caja/plugin/DomitaTest.java:71: poll(20000, 1000, new Check() { On 2010/09/29 06:20:02, jasvir wrote:
:(
Yeah ... for some reason, stuff now takes a little bit longer. :P http://codereview.appspot.com/2206045/
