http://codereview.appspot.com/4591043/diff/3001/tests/com/google/caja/parser/html/NodesTest.java File tests/com/google/caja/parser/html/NodesTest.java (right):
http://codereview.appspot.com/4591043/diff/3001/tests/com/google/caja/parser/html/NodesTest.java#newcode657 tests/com/google/caja/parser/html/NodesTest.java:657: RenderContext renderContext = new ScriptFixupRenderContext(cat) If I set withAsciiOnly to false (as we need to do inside VanillaCajaHtmlSerializer), the renderContext variable no longer remains as an instance of ScriptFixupRenderContext and the new logic introduced in this patch in Nodes.java won't get used and an IllegalArgumentException will be thrown as before. Please see http://codereview.appspot.com/4575056/diff/3/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/VanillaCajaHtmlSerializer.java for the shindig change which finally worked for me (but is not acceptable since we do need to set withAsciiOnly to false) and lines 598 - 604 of http://codereview.appspot.com/4535111/diff/18001/tests/com/google/caja/parser/html/NodesTest.java to see how your change can be modified to raise an exception. http://codereview.appspot.com/4591043/
