On Tue, Jun 14, 2011 at 9:13 AM, <[email protected]> wrote: > While this patch is fine as it stands, as discussed with Mike offline, > this change is in the TCB and would be safer if RenderContext controlled > whether fixup will be applied or not (as in the first patch set) rather > than applying it unconditionally. > > http://codereview.appspot.com/4591043/
Applying this conditionally sounds fine. The first patch set had a different problem that the way the ScriptFixupRenderContext was defined and used was not going to go well with the VanillaCajaHtmlSerializer code that I had pointed out to you - if you could fix that (basically modify the first patch set so that the comment/test mentioned in http://codereview.appspot.com/4591043/diff/3001/tests/com/google/caja/parser/html/NodesTest.java#newcode657 is addressed), that should be an acceptable solution? Thanks, Anupama.
