a few nits but otherwise lgtm

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/debug.js
File src/com/google/caja/ses/debug.js (right):

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/debug.js#newcode44
src/com/google/caja/ses/debug.js:44: * make it otheriwse unreachable.
Replace it with a reachable
typo "otheriwse"

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode356
src/com/google/caja/ses/repairES5.js:356: * unifortunately specified
that a simple assignment to a
typo "unifortunately"

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode363
src/com/google/caja/ses/repairES5.js:363: * best practices, of this
previous code used assignment to
"of" should be "if"?

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode368
src/com/google/caja/ses/repairES5.js:368: * "constructor" is a function
whose "prototype" is this obj. If so,
this definition of "prototypical", while precise, is not very helpful.
it took me a while to figure out an example of a prototypical object.
how about mention something like: Object.prototype and
Function.prototype are prototypical.

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode475
src/com/google/caja/ses/repairES5.js:475: *
<p>"makeDelayedTamperProof()" must only be called once.
how about throw an error if it's called more than once?

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode1642
src/com/google/caja/ses/repairES5.js:1642: * Do Error instances on thos
platform carry own properties that we
typo "thos"

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/startSES.js
File src/com/google/caja/ses/startSES.js (right):

http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/startSES.js#newcode258
src/com/google/caja/ses/startSES.js:258: func.prototype = null;
what's the rationale for setting prototype to null?

http://codereview.appspot.com/5648043/

Reply via email to