http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/debug.js File src/com/google/caja/ses/debug.js (right):
http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/debug.js#newcode44 src/com/google/caja/ses/debug.js:44: * make it otheriwse unreachable. Replace it with a reachable On 2012/02/11 08:36:58, felix8a wrote:
typo "otheriwse"
Done. http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js File src/com/google/caja/ses/repairES5.js (right): http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode356 src/com/google/caja/ses/repairES5.js:356: * unifortunately specified that a simple assignment to a On 2012/02/11 08:36:58, felix8a wrote:
typo "unifortunately"
Done. http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode363 src/com/google/caja/ses/repairES5.js:363: * best practices, of this previous code used assignment to On 2012/02/11 08:36:58, felix8a wrote:
"of" should be "if"?
Done. http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode368 src/com/google/caja/ses/repairES5.js:368: * "constructor" is a function whose "prototype" is this obj. If so, On 2012/02/11 08:36:58, felix8a wrote:
this definition of "prototypical", while precise, is not very helpful.
it took
me a while to figure out an example of a prototypical object. how
about mention
something like: Object.prototype and Function.prototype are
prototypical. Done. http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode475 src/com/google/caja/ses/repairES5.js:475: * <p>"makeDelayedTamperProof()" must only be called once. On 2012/02/11 08:36:58, felix8a wrote:
how about throw an error if it's called more than once?
Done. http://codereview.appspot.com/5648043/diff/3001/src/com/google/caja/ses/repairES5.js#newcode1642 src/com/google/caja/ses/repairES5.js:1642: * Do Error instances on thos platform carry own properties that we On 2012/02/11 08:36:58, felix8a wrote:
typo "thos"
Done. http://codereview.appspot.com/5648043/
