http://codereview.appspot.com/6182049/diff/12003/src/com/google/caja/plugin/caja.js
File src/com/google/caja/plugin/caja.js (right):

http://codereview.appspot.com/6182049/diff/12003/src/com/google/caja/plugin/caja.js#newcode49
src/com/google/caja/plugin/caja.js:49: ATTRIBUTETYPES: undefined,
please quote these keys for Closure

http://codereview.appspot.com/6182049/diff/12003/src/com/google/caja/plugin/caja.js#newcode246
src/com/google/caja/plugin/caja.js:246: if
(partial.targetAttributePresets) {
please use partial['targetAttributePresets'], and below.

when you use o.y and Closure doesn't have a specific type for o, it
assumes o is an Object, and .y is a property of all Objects, and
1, it will complain if there isn't any assignment o2.y = z
2, it will rename all occurrences of .y to something shorter
which screws up when the .y is a name in an api for external linkage.

http://codereview.appspot.com/6182049/diff/12003/tests/com/google/caja/plugin/es53-test-target-attribute-presets.js
File tests/com/google/caja/plugin/es53-test-target-attribute-presets.js
(right):

http://codereview.appspot.com/6182049/diff/12003/tests/com/google/caja/plugin/es53-test-target-attribute-presets.js#newcode73
tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:73:
'action="foo"');
shouldn't this be target="foo"?  did this pass?

http://codereview.appspot.com/6182049/

Reply via email to