http://codereview.appspot.com/6182049/diff/12003/src/com/google/caja/plugin/caja.js File src/com/google/caja/plugin/caja.js (right):
http://codereview.appspot.com/6182049/diff/12003/src/com/google/caja/plugin/caja.js#newcode49 src/com/google/caja/plugin/caja.js:49: ATTRIBUTETYPES: undefined, On 2012/05/09 16:06:34, felix8a wrote:
please quote these keys for Closure
Done. http://codereview.appspot.com/6182049/diff/12003/src/com/google/caja/plugin/caja.js#newcode246 src/com/google/caja/plugin/caja.js:246: if (partial.targetAttributePresets) { On 2012/05/09 16:06:34, felix8a wrote:
please use partial['targetAttributePresets'], and below.
when you use o.y and Closure doesn't have a specific type for o, it
assumes o is
an Object, and .y is a property of all Objects, and 1, it will complain if there isn't any assignment o2.y = z 2, it will rename all occurrences of .y to something shorter which screws up when the .y is a name in an api for external linkage.
Done. http://codereview.appspot.com/6182049/diff/12003/tests/com/google/caja/plugin/es53-test-target-attribute-presets.js File tests/com/google/caja/plugin/es53-test-target-attribute-presets.js (right): http://codereview.appspot.com/6182049/diff/12003/tests/com/google/caja/plugin/es53-test-target-attribute-presets.js#newcode73 tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:73: 'action="foo"'); On 2012/05/09 16:06:34, felix8a wrote:
shouldn't this be target="foo"? did this pass?
No it fails (whew!). I think I ran the test with a hacked-up html4-defs file and needed to do an 'ant clean'. http://codereview.appspot.com/6182049/
