snapshot

https://codereview.appspot.com/6827077/diff/54001/src/com/google/caja/ses/exportsToSES.js
File src/com/google/caja/ses/exportsToSES.js (right):

https://codereview.appspot.com/6827077/diff/54001/src/com/google/caja/ses/exportsToSES.js#newcode28
src/com/google/caja/ses/exportsToSES.js:28: ses.rewriter___ = {};
On 2013/01/02 19:48:32, kpreid2 wrote:
On 2013/01/02 19:42:59, Jasvir wrote:
> On 2013/01/02 18:59:16, kpreid2 wrote:
> > I don't like using "___" here, which suggests it is a
> > hidden-from-guest-code variable, which does not exist in
> > ES5. Use an ordinary "private" naming convention instead.
>
> Done.

I see no private marker at all, now.

Done.

https://codereview.appspot.com/6827077/diff/49022/src/com/google/caja/ses/exportsToSES.js
File src/com/google/caja/ses/exportsToSES.js (right):

https://codereview.appspot.com/6827077/diff/49022/src/com/google/caja/ses/exportsToSES.js#newcode27
src/com/google/caja/ses/exportsToSES.js:27: (function (ses, global) {
On 2013/01/02 19:48:32, kpreid2 wrote:
no space between function and (

Done.

https://codereview.appspot.com/6827077/

Reply via email to