snapshot
https://codereview.appspot.com/6827077/diff/29022/src/com/google/caja/parser/quasiliteral/RewriterMessageType.java File src/com/google/caja/parser/quasiliteral/RewriterMessageType.java (right): https://codereview.appspot.com/6827077/diff/29022/src/com/google/caja/parser/quasiliteral/RewriterMessageType.java#newcode191 src/com/google/caja/parser/quasiliteral/RewriterMessageType.java:191: TOP_LEVEL_FUNC_INCOMPATIBLE_WITH_CAJA( In a separate CL. https://codereview.appspot.com/6827077/diff/29022/src/com/google/caja/ses/exportsToSES.js File src/com/google/caja/ses/exportsToSES.js (right): https://codereview.appspot.com/6827077/diff/29022/src/com/google/caja/ses/exportsToSES.js#newcode32 src/com/google/caja/ses/exportsToSES.js:32: exports = void 0; On 2012/12/18 20:04:22, kpreid2 wrote:
Can we 'delete exports'?
Done. https://codereview.appspot.com/6827077/diff/29022/src/com/google/caja/ses/whitelist.js File src/com/google/caja/ses/whitelist.js (right): https://codereview.appspot.com/6827077/diff/29022/src/com/google/caja/ses/whitelist.js#newcode145 src/com/google/caja/ses/whitelist.js:145: inES5Mode: t On 2012/12/18 20:04:22, kpreid2 wrote:
does not belong in non-test code, as I said before
Done. https://codereview.appspot.com/6827077/diff/29022/tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java File tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java (right): https://codereview.appspot.com/6827077/diff/29022/tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java#newcode790 tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java:790: RewriterMessageType.TOP_LEVEL_FUNC_INCOMPATIBLE_WITH_CAJA); Separate CL for top level functions. https://codereview.appspot.com/6827077/diff/29022/tests/com/google/caja/plugin/es53-test-gotchas-guest.html File tests/com/google/caja/plugin/es53-test-gotchas-guest.html (right): https://codereview.appspot.com/6827077/diff/29022/tests/com/google/caja/plugin/es53-test-gotchas-guest.html#newcode16 tests/com/google/caja/plugin/es53-test-gotchas-guest.html:16: On 2012/12/18 20:04:22, kpreid2 wrote:
These tests would be a better fit in es53-test-language-guest, I
think.
Furthermore, they need not be es5-only.
Done. https://codereview.appspot.com/6827077/
