All but domado.js reviewed for real.
On domado.js, I just don't have enough context (or time to learn) to
give this a proper review.
Once WeakMap.prototype.constructor is fixed, all but domado LGTM.
https://codereview.appspot.com/8612048/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/8612048/diff/1/src/com/google/caja/plugin/domado.js#newcode574
src/com/google/caja/plugin/domado.js:574: var ProxyHandler =
domitaModules.ProxyHandler;
Please place this declaration/initialization after the following
conditional, since it is only relevant if the condition falls through.
https://codereview.appspot.com/8612048/diff/1/src/com/google/caja/plugin/domado.js#newcode581
src/com/google/caja/plugin/domado.js:581: if (/^weakmap:/.test(name)) {
weakMapMagicName = name; }
This seems totally bizarre. I don't understand the purpose of this or
why it is safe.
https://codereview.appspot.com/8612048/diff/1/src/com/google/caja/ses/WeakMap.js
File src/com/google/caja/ses/WeakMap.js (right):
https://codereview.appspot.com/8612048/diff/1/src/com/google/caja/ses/WeakMap.js#newcode500
src/com/google/caja/ses/WeakMap.js:500: WeakMap = DoubleWeakMap;
after:
WeakMap.prototype.constructor = WeakMap;
Otherwise, WeakMap.prototype.constructor would be something OurWeakMap.
https://codereview.appspot.com/8612048/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
