Non-domado parts LGTM. I leave the domado parts to Ihab.


https://codereview.appspot.com/8612048/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/8612048/diff/1/src/com/google/caja/plugin/domado.js#newcode581
src/com/google/caja/plugin/domado.js:581: if (/^weakmap:/.test(name)) {
weakMapMagicName = name; }
On 2013/04/15 21:09:41, kpreid2 wrote:
I am uncertain what part you are referring to.

Nevermind.

https://codereview.appspot.com/8612048/diff/16001/src/com/google/caja/ses/WeakMap.js
File src/com/google/caja/ses/WeakMap.js (right):

https://codereview.appspot.com/8612048/diff/16001/src/com/google/caja/ses/WeakMap.js#newcode462
src/com/google/caja/ses/WeakMap.js:462: if (typeof HostWeakMap ===
'function') (function() {
On 2013/04/15 21:19:55, kpreid2 wrote:
On 2013/04/15 21:17:34, ihab.awad wrote:
> Still with the syntactic neologisms. Gefurfifier. :(

OK, OK, changed.

I don't see the curlies. Did you forget to snapshot?

https://codereview.appspot.com/8612048/

--

--- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to