Please excuse me for volunteering when I wasn't asked; I just saw a few
things...
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/html-emitter.js
File src/com/google/caja/plugin/html-emitter.js (right):
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/html-emitter.js#newcode449
src/com/google/caja/plugin/html-emitter.js:449: function
makeCssUriHandler(baseUri, domicileProp, mime) {
suggest 'method' instead of 'domicileProp' to be more specific than
generic-meta
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/html-emitter.js#newcode457
src/com/google/caja/plugin/html-emitter.js:457: // TODO: Why is this
setting mime type to image/*?
Because the only things CSS used to fetch are background images? Perhaps
move the mime type parameter into sanitizecss.js, so that even if it's
still always image/* it's more explicit.
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/sanitizecss.js
File src/com/google/caja/plugin/sanitizecss.js (right):
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/sanitizecss.js#newcode33
src/com/google/caja/plugin/sanitizecss.js:33: * \@overrides window
setTimeout
unused setTimeout
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html
File tests/com/google/caja/plugin/es53-test-css-imports-guest.html
(right):
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode2
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:2: -
Copyright (C) 2011 Google Inc.
update date
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode17
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:17: <div
class="testcont1ainer waiting" id="testCssImports">
misspelled 'testcontainer'
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode18
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:18: <base
href="/ant-testlib/com/google/caja/plugin/">
Not necessary and interferes with some things such as the new 'run from
source tree' feature.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode19
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:19: <link
href="es53-test-css-imports-1.css" rel="stylesheet"></link>
</link> is wrong
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode36
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:36:
jsunitRegisterIf(inES5Mode,
Why is this test specific to ES5 mode? Won't ES5/3 also support @import
with the same outcome, in which case we should want our tests to inform
us of discrepancies?
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode38
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:38:
function testCssImports () {
no space before (
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode41
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:41: var
color = directAccess.getComputedStyle(candidate, 'background-color');
Maybe mention why you're using directAccess?
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode49
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:49:
assertExpectedColor({rgb: 0x000000}, "shouldbezero");
single quotes
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode57
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:57:
pass('testCssImports');
Please put a TODO here to move this pass() into the main line of the
test once we have fixed assertAsynchronousRequirement.
https://codereview.appspot.com/8778046/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
