https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/html-emitter.js
File src/com/google/caja/plugin/html-emitter.js (right):
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/html-emitter.js#newcode449
src/com/google/caja/plugin/html-emitter.js:449: function
makeCssUriHandler(baseUri, domicileProp, mime) {
On 2013/04/17 14:08:51, kpreid2 wrote:
suggest 'method' instead of 'domicileProp' to be more specific than
generic-meta
Done.
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/html-emitter.js#newcode457
src/com/google/caja/plugin/html-emitter.js:457: // TODO: Why is this
setting mime type to image/*?
There are more of mimetype clean ups I accumulated. I'll do the changes
you suggest in a later CL.
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/sanitizecss.js
File src/com/google/caja/plugin/sanitizecss.js (right):
https://codereview.appspot.com/8778046/diff/1/src/com/google/caja/plugin/sanitizecss.js#newcode33
src/com/google/caja/plugin/sanitizecss.js:33: * \@overrides window
setTimeout
On 2013/04/17 14:08:51, kpreid2 wrote:
unused setTimeout
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html
File tests/com/google/caja/plugin/es53-test-css-imports-guest.html
(right):
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode2
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:2: -
Copyright (C) 2011 Google Inc.
On 2013/04/17 14:08:51, kpreid2 wrote:
update date
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode17
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:17: <div
class="testcont1ainer waiting" id="testCssImports">
On 2013/04/17 14:08:51, kpreid2 wrote:
misspelled 'testcontainer'
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode18
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:18: <base
href="/ant-testlib/com/google/caja/plugin/">
On 2013/04/17 14:08:51, kpreid2 wrote:
Not necessary and interferes with some things such as the new 'run
from source
tree' feature.
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode19
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:19: <link
href="es53-test-css-imports-1.css" rel="stylesheet"></link>
On 2013/04/17 14:08:51, kpreid2 wrote:
</link> is wrong
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode36
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:36:
jsunitRegisterIf(inES5Mode,
On 2013/04/17 14:08:51, kpreid2 wrote:
Why is this test specific to ES5 mode? Won't ES5/3 also support
@import with the
same outcome, in which case we should want our tests to inform us of
discrepancies?
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode38
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:38:
function testCssImports () {
On 2013/04/17 14:08:51, kpreid2 wrote:
no space before (
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode41
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:41: var
color = directAccess.getComputedStyle(candidate, 'background-color');
On 2013/04/17 14:08:51, kpreid2 wrote:
Maybe mention why you're using directAccess?
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode49
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:49:
assertExpectedColor({rgb: 0x000000}, "shouldbezero");
On 2013/04/17 14:08:51, kpreid2 wrote:
single quotes
Done.
https://codereview.appspot.com/8778046/diff/1/tests/com/google/caja/plugin/es53-test-css-imports-guest.html#newcode57
tests/com/google/caja/plugin/es53-test-css-imports-guest.html:57:
pass('testCssImports');
On 2013/04/17 14:08:51, kpreid2 wrote:
Please put a TODO here to move this pass() into the main line of the
test once
we have fixed assertAsynchronousRequirement.
Done.
https://codereview.appspot.com/8778046/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
