https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/demos/playground/client/ui/PlaygroundView.java
File src/com/google/caja/demos/playground/client/ui/PlaygroundView.java
(right):
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/demos/playground/client/ui/PlaygroundView.java#newcode541
src/com/google/caja/demos/playground/client/ui/PlaygroundView.java:541:
// Skip rewriting jquery and jqueryui when loaded from the google cdn
long line
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/domado.js#newcode5269
src/com/google/caja/plugin/domado.js:5269:
subDomicile.htmlEmitterTarget,
Indent 2 more spaces
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/domado.js#newcode6230
src/com/google/caja/plugin/domado.js:6230:
URI.utils.resolve(domicile.pseudoLocation.href, uri),
Indent 2 more spaces.
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/domado.js#newcode6230
src/com/google/caja/plugin/domado.js:6230:
URI.utils.resolve(domicile.pseudoLocation.href, uri),
Why was this resolution not being done before, and why is now the time
to start doing it? It looks reasonable enough, but I'm wondering what
the backstory is.
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/es53-frame-group.js
File src/com/google/caja/plugin/es53-frame-group.js (right):
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/es53-frame-group.js#newcode305
src/com/google/caja/plugin/es53-frame-group.js:305: undefined /*
cajoling proxy unused in es53 */, domicile, imports);
Long line.
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/html-emitter.js
File src/com/google/caja/plugin/html-emitter.js (right):
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/html-emitter.js#newcode49
src/com/google/caja/plugin/html-emitter.js:49: * fly (used only in
SES)
It's not really a proxy because it doesn't actually fetch or
intermediate any content. It's more just a URI rewriter. I would not
call it a "proxy" so as to avoid confusion with real HTTP proxy type
stuff.
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/html-emitter.js#newcode55
src/com/google/caja/plugin/html-emitter.js:55:
Extra blank line.
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/html-emitter.js#newcode58
src/com/google/caja/plugin/html-emitter.js:58: opt_mitigatingProxy,
opt_domicile, opt_guestGlobal) {
Indent 2 spaces.
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/plugin/html-emitter.js#newcode547
src/com/google/caja/plugin/html-emitter.js:547:
evaluateUntrustedScript(url, src, true, doesNotNeedMitigation);
Passing 'doesNotNeedMitigation' as the value of formal 'opt_mitigate'?
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/ses/startSES.js
File src/com/google/caja/ses/startSES.js (right):
https://codereview.appspot.com/7381051/diff/13001/src/com/google/caja/ses/startSES.js#newcode734
src/com/google/caja/ses/startSES.js:734: function compileExpr(src,
doesNotNeedMitigation, opt_sourcePosition) {
Please change throughout to 'mitigate' with appropriate boolean sense.
Otherwise it's too confusing to keep track of everything.
https://codereview.appspot.com/7381051/diff/13001/tests/com/google/caja/plugin/Es5BrowserTest.java
File tests/com/google/caja/plugin/Es5BrowserTest.java (right):
https://codereview.appspot.com/7381051/diff/13001/tests/com/google/caja/plugin/Es5BrowserTest.java#newcode34
tests/com/google/caja/plugin/Es5BrowserTest.java:34: public void
testCajolingProxy() throws Exception {
s/Cajole/Mitigate/ ?
https://codereview.appspot.com/7381051/diff/13001/tests/com/google/caja/plugin/es53-test-cajoling-proxy.js
File tests/com/google/caja/plugin/es53-test-cajoling-proxy.js (right):
https://codereview.appspot.com/7381051/diff/13001/tests/com/google/caja/plugin/es53-test-cajoling-proxy.js#newcode19
tests/com/google/caja/plugin/es53-test-cajoling-proxy.js:19: * @requires
caja, jsunitRun, readyToTest
document, jsunitRegister
https://codereview.appspot.com/7381051/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
