https://codereview.appspot.com/7381051/diff/41001/src/com/google/caja/ses/mitigateGotchas.js
File src/com/google/caja/ses/mitigateGotchas.js (right):
https://codereview.appspot.com/7381051/diff/41001/src/com/google/caja/ses/mitigateGotchas.js#newcode201
src/com/google/caja/ses/mitigateGotchas.js:201: return (options && opt
in options) ? opt : defaultOption;
If opt is in options, this returns opt itself. From looking at how it is
used, I suspect this is not what you intend.
https://codereview.appspot.com/7381051/diff/41001/src/com/google/caja/ses/mitigateGotchas.js#newcode213
src/com/google/caja/ses/mitigateGotchas.js:213: resolved.parseProgram =
true;
Please add a TODO that we should only mandate this if a to-be-added test
in repairES5.js indicates that this platform has the relevant problem.
https://codereview.appspot.com/7381051/diff/41001/src/com/google/caja/ses/startSES.js
File src/com/google/caja/ses/startSES.js (right):
https://codereview.appspot.com/7381051/diff/41001/src/com/google/caja/ses/startSES.js#newcode844
src/com/google/caja/ses/startSES.js:844: function compileModule(modSrc,
doesNotNeedMitigation, opt_sourcePosition) {
Make the same change to compileModule that you made to compileExpr.
Exactly the same issues apply.
On the doc-comment, probably better to modify this one to delegate to
compileExpr rather than duplicating. But either way.
https://codereview.appspot.com/7381051/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
