LGTM
https://codereview.appspot.com/9864044/diff/3001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/9864044/diff/3001/src/com/google/caja/ses/repairES5.js#newcode3059
src/com/google/caja/ses/repairES5.js:3059: // the forEach binds this to
the error instance
Technically this terminology is wrong. forEach doesn't "bind" it in the
sense of making a new bound function. It does invoke it with the error
instance bound to "this", which accurately describes the point you're
making.
https://codereview.appspot.com/9864044/diff/3001/src/com/google/caja/ses/repairES5.js#newcode3066
src/com/google/caja/ses/repairES5.js:3066: // Note: not adequate for
cross-frame use, but we currently don't care
This will no longer be safe once SES allows mutation of [[Prototype]] on
extensible objects. Let's abstract this into an isError predicate, and
for now define isError as checking that objToString.call(object) ends
with "Error]". This will also not be an adequate check in SES-on-ES6, so
we should still include a note to revisit this then.
https://codereview.appspot.com/9864044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
