LGTM
https://codereview.appspot.com/9864044/diff/3001/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/9864044/diff/3001/src/com/google/caja/ses/repairES5.js#newcode3066
src/com/google/caja/ses/repairES5.js:3066: // Note: not adequate for
cross-frame use, but we currently don't care
On 2013/05/31 20:52:47, kpreid2 wrote:
How so? ES6 is not allowing setting [[Class]], is it? Or will there
ways to have
user-defined objects for which Object.prototype.toString varies?
On ES6, Object.prototype.toString, instead of accessing the internal
[[Class]] property (which is going away anyway), will instead access a
unique-symbol-named property. Thus, any object can have any
Object.prototype.toString.call(obj) result. We will then need to revisit
*all* the places where we're using Object.prototype.toString as a brand
check.
So yes, it is not worth abstracting this further until we abstract all
such brand checks.
https://codereview.appspot.com/9864044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
