On 2013/06/06 20:24:27, felix8a wrote:
lgtm
Unfortunately r5440 (mitigate typeof by hiding ReferenceError instead of
rewriting typeof) caused broad test failures (that is, reduction in pass
counts) in this change. Looks like this in each file:
Sizzle: global failure (2, 0, 2)
TypeError: originaljQuery.ajax is not a function
(Firefox) or in Chrome's wording,
TypeError: Object jQuery has no method 'ajax'
These errors are about the dummy value set by jQuery testinit.js
'originaljQuery = this.jQuery || "jQuery"', so evidently this is not
picking up a real jQuery object when it should. I have not yet figured
out enough about the order of events to explain it.
I am concerned that this may represent an actual regression in r5440.
https://codereview.appspot.com/10087044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.