On 2013/06/06 22:46:04, kpreid2 wrote:
On 2013/06/06 20:24:27, felix8a wrote:
> lgtm
Unfortunately r5440 (mitigate typeof by hiding ReferenceError instead
of
rewriting typeof) caused broad test failures (that is, reduction in
pass counts)
in this change. Looks like this in each file:
Sizzle: global failure (2, 0, 2)
TypeError: originaljQuery.ajax is not a function
Ihab and I looked at this today: the cause turned out to be that the
test suite is loading two copies of jQuery, one of which should end up
in the 'originaljQuery' variable. That one is minified, and the minifier
replaced a string escape "\uFEFF" with a literal U+FEFF, which our
parser for mitigation rejected. It is as yet unclear why r5440 made a
difference; for now, I simply replaced the character in the minified
jQuery with the escaped form.
https://codereview.appspot.com/10087044/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
