Significant changes to acceptableProblems; change description updated.
See below for why.
https://codereview.appspot.com/9979047/diff/1/src/com/google/caja/ses/repairES5.js
File src/com/google/caja/ses/repairES5.js (right):
https://codereview.appspot.com/9979047/diff/1/src/com/google/caja/ses/repairES5.js#newcode240
src/com/google/caja/ses/repairES5.js:240: * An object whose keys are
problem names and whose values are one of
On 2013/06/06 21:59:52, MarkM wrote:
"whose enumerable keys", since you're finding them with a for/in loop.
Done.
https://codereview.appspot.com/9979047/diff/1/src/com/google/caja/ses/repairES5.js#newcode256
src/com/google/caja/ses/repairES5.js:256: */
I've added a warning here that permitting unrepaired problems is
potentially dangerous to SES itself.
https://codereview.appspot.com/9979047/diff/1/src/com/google/caja/ses/repairES5.js#newcode3729
src/com/google/caja/ses/repairES5.js:3729: repair: undefined, //
workaround is too slow
On 2013/06/06 21:59:52, MarkM wrote:
Given the rest of this CL, why not reinstate this repair?
Done. However, this has significant consequences:
1. That same repair also applies to PUSH_DOES_NOT_THROW_ON_FROZEN_ARRAY
and PUSH_IGNORES_FROZEN, so I have to add it to those as well or they
will be reported as “Accidentally repaired”.
2. But we don't want to run the slow repair in Caja, and we can't
express "don't repair, but abort" for PUSH_IGNORES_FROZEN using my
current scheme.
Therefore, I have changed the format of acceptableProblems to specify
'permit' and 'doNotRepair' as independent flags; doNotRepair no longer
implies permit.
Also, repair_PUSH_IGNORES_SEALED is now done by default when using
caja.js: in order to get the old behavior of never repairing you have to
specify NKESV (which Playground and Apps Script do, so most users will
see no difference). I could change this, but it seems to be the right
thing on principle.
https://codereview.appspot.com/9979047/diff/1/src/com/google/caja/ses/repairES5.js#newcode4017
src/com/google/caja/ses/repairES5.js:4017: }
I have added logging of ignored problems.
https://codereview.appspot.com/9979047/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
