LGTM
https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin/BrowserTestCase.java
File tests/com/google/caja/plugin/BrowserTestCase.java (right):
https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin/BrowserTestCase.java#newcode120
tests/com/google/caja/plugin/BrowserTestCase.java:120: {
I don't think the { on another line is our usual coding style, is it?
https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin/WebDriverHandle.java
File tests/com/google/caja/plugin/WebDriverHandle.java (right):
https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin/WebDriverHandle.java#newcode231
tests/com/google/caja/plugin/WebDriverHandle.java:231: // ignore
Please log this failure.
https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin/WebDriverHandle.java#newcode262
tests/com/google/caja/plugin/WebDriverHandle.java:262: private void
saveToFile(String fileName, byte[] bytes) {
I'm pretty sure we already have these somewhere in our classpath...
Yeah, try org.apache.commons.io.FileUtils; has string and array
versions.
https://codereview.appspot.com/9830047/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
