@r5446

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin/WebDriverHandle.java
File tests/com/google/caja/plugin/WebDriverHandle.java (right):

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin/WebDriverHandle.java#newcode231
tests/com/google/caja/plugin/WebDriverHandle.java:231: // ignore
On 2013/06/12 16:43:07, kpreid2 wrote:
Please log this failure.

Done.

https://codereview.appspot.com/9830047/diff/4001/tests/com/google/caja/plugin/WebDriverHandle.java#newcode262
tests/com/google/caja/plugin/WebDriverHandle.java:262: private void
saveToFile(String fileName, byte[] bytes) {
On 2013/06/12 16:43:07, kpreid2 wrote:
I'm pretty sure we already have these somewhere in our classpath...

Yeah, try org.apache.commons.io.FileUtils; has string and array
versions.

ok I just tried using FileUtils instead and it turns out not to be any
simpler, because I still need all the try/catch code. basically, it just
saves 2 lines of code. so, I'm not doing it.

https://codereview.appspot.com/9830047/

--

--- You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to