lgtm++ -- comments and questions should not block checkin.
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/browser-test-case.js
File tests/com/google/caja/plugin/browser-test-case.js (right):
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/browser-test-case.js#newcode119
tests/com/google/caja/plugin/browser-test-case.js:119: * setUp,
tearDown,
Missing @provides basicCajaConfig?
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-cajajs-invocation.js
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js
(right):
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-cajajs-invocation.js#newcode86
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:86:
forceES5Mode: inES5Mode
This is same as basicCajaConfig....
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js
File
tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js
(right):
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js#newcode69
tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js:69:
caja.initialize({
Copy basicCajaConfig and add to it?
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-scan-guest.js
File tests/com/google/caja/plugin/es53-test-scan-guest.js (right):
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-scan-guest.js#newcode169
tests/com/google/caja/plugin/es53-test-scan-guest.js:169:
/defProp\(this, ?name, ?\{/.exec(String(desc.set)) ||
A little confused about how this pattern matches minified code; why just
adding the "?"?
https://codereview.appspot.com/10450043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
