https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/browser-test-case.js
File tests/com/google/caja/plugin/browser-test-case.js (right):
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/browser-test-case.js#newcode119
tests/com/google/caja/plugin/browser-test-case.js:119: * setUp,
tearDown,
On 2013/06/21 18:22:24, ihab.awad wrote:
Missing @provides basicCajaConfig?
Done.
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-cajajs-invocation.js
File tests/com/google/caja/plugin/es53-test-cajajs-invocation.js
(right):
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-cajajs-invocation.js#newcode86
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:86:
forceES5Mode: inES5Mode
On 2013/06/21 18:22:24, ihab.awad wrote:
This is same as basicCajaConfig....
Done, everywhere in this file.
Originally I left this alone because I thought this file had several
different caja configs, but now I see they don't actually need to be
different. (I assume the lack of forceES5Mode in testReinitialization is
unnecessary.)
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-cajajs-invocation.js#newcode91
tests/com/google/caja/plugin/es53-test-cajajs-invocation.js:91:
getUrlParam('minified', 'PARAM MISSING'),
Changed this to use minifiedMode.
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js
File
tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js
(right):
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js#newcode69
tests/com/google/caja/plugin/es53-test-custom-cajoling-service-client.js:69:
caja.initialize({
On 2013/06/21 18:22:24, ihab.awad wrote:
Copy basicCajaConfig and add to it?
Eh, there's not a great way to do that — there's no basic “copy a
record” operation. I didn't want to clutter the code with reflective
fiddling.
Should we arrange to have something like that?
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-scan-guest.js
File tests/com/google/caja/plugin/es53-test-scan-guest.js (right):
https://codereview.appspot.com/10450043/diff/1/tests/com/google/caja/plugin/es53-test-scan-guest.js#newcode169
tests/com/google/caja/plugin/es53-test-scan-guest.js:169:
/defProp\(this, ?name, ?\{/.exec(String(desc.set)) ||
On 2013/06/21 18:22:24, ihab.awad wrote:
A little confused about how this pattern matches minified code; why
just adding the "?"?
The only thing the minifier does to this code is remove whitespace, so
I'm making whitespace optional in the pattern.
https://codereview.appspot.com/10450043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
