https://codereview.appspot.com/10572043/diff/1/tests/com/google/caja/plugin/es53-test-domado-events-guest.html
File tests/com/google/caja/plugin/es53-test-domado-events-guest.html
(right):
https://codereview.appspot.com/10572043/diff/1/tests/com/google/caja/plugin/es53-test-domado-events-guest.html#newcode371
tests/com/google/caja/plugin/es53-test-domado-events-guest.html:371: var
clicks = 0;
I don't like the name 'clicks' because it suggests this is a counter
rather than state-machine (more regular than irregular behavior). How
about 'state', 'step', 'phase', or 'progress'?
https://codereview.appspot.com/10572043/diff/1/tests/com/google/caja/plugin/es53-test-domado-events-guest.html#newcode388
tests/com/google/caja/plugin/es53-test-domado-events-guest.html:388:
container.removeEventListener('mouseup', check, false);
'check' here is bound to the named function which is !== to the
jsunitCallback wrapper which was added, so this removeEventListener does
nothing.
Also, if it throws for some reason, the test will "pass then fail", so
I'd rather see removeEventListener(…) before pass(…) just for cleaner
output. No harm either way.
https://codereview.appspot.com/10572043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
