https://codereview.appspot.com/10572043/diff/1/tests/com/google/caja/plugin/es53-test-domado-events-guest.html
File tests/com/google/caja/plugin/es53-test-domado-events-guest.html
(right):
https://codereview.appspot.com/10572043/diff/1/tests/com/google/caja/plugin/es53-test-domado-events-guest.html#newcode371
tests/com/google/caja/plugin/es53-test-domado-events-guest.html:371: var
clicks = 0;
On 2013/06/26 16:55:33, kpreid2 wrote:
I don't like the name 'clicks' because it suggests this is a counter
rather than
state-machine (more regular than irregular behavior). How about
'state', 'step',
'phase', or 'progress'?
Done.
https://codereview.appspot.com/10572043/diff/1/tests/com/google/caja/plugin/es53-test-domado-events-guest.html#newcode388
tests/com/google/caja/plugin/es53-test-domado-events-guest.html:388:
container.removeEventListener('mouseup', check, false);
On 2013/06/26 16:55:33, kpreid2 wrote:
'check' here is bound to the named function which is !== to the
jsunitCallback
wrapper which was added, so this removeEventListener does nothing.
ah, yeah, good catch. fixed.
https://codereview.appspot.com/10572043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
