lgtm++
If there is a way to add actual test of the elements, that would be
nice. Not sure how much can be automated though....
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode4427
src/com/google/caja/plugin/domado.js:4427: domClass: 'HTMLAudioElement'
Is there some logical order to where the defineElement()-s are sprinkled
around?
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode4430
src/com/google/caja/plugin/domado.js:4430: var element =
tameDocument.createElement('img');
Do you mean createElement('audio')?
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode5348
src/com/google/caja/plugin/domado.js:5348: if (width !== undefined) {
element.width = width; }
Should be (+width), etc?
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode5472
src/com/google/caja/plugin/domado.js:5472: return
String(privates.feral.canPlayType(String(type)));
Is our idiom String(x) or ('' + x)? Just good to be consistent either
way.
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode5512
src/com/google/caja/plugin/domado.js:5512: if (value !== undefined) {
element.value = value; }
Should be ('' + text), etc?
https://codereview.appspot.com/10882043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
