https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode4427
src/com/google/caja/plugin/domado.js:4427: domClass: 'HTMLAudioElement'
On 2013/07/02 19:41:23, ihab.awad wrote:
Is there some logical order to where the defineElement()-s are
sprinkled around?
Alphabetical.
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode4430
src/com/google/caja/plugin/domado.js:4430: var element =
tameDocument.createElement('img');
On 2013/07/02 19:41:23, ihab.awad wrote:
Do you mean createElement('audio')?
So I do. Added a test.
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode5348
src/com/google/caja/plugin/domado.js:5348: if (width !== undefined) {
element.width = width; }
On 2013/07/02 19:41:23, ihab.awad wrote:
Should be (+width), etc?
No, this is a tame element so we rely on the property taming. If it
weren't, the 'return element;' at the end would be a problem.
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode5472
src/com/google/caja/plugin/domado.js:5472: return
String(privates.feral.canPlayType(String(type)));
On 2013/07/02 19:41:23, ihab.awad wrote:
Is our idiom String(x) or ('' + x)? Just good to be consistent either
way.
'' +, but I hope this code eventually goes the way of functional
composition.
https://codereview.appspot.com/10882043/diff/1/src/com/google/caja/plugin/domado.js#newcode5512
src/com/google/caja/plugin/domado.js:5512: if (value !== undefined) {
element.value = value; }
On 2013/07/02 19:41:23, ihab.awad wrote:
Should be ('' + text), etc?
Same as above.
https://codereview.appspot.com/10882043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
