I'm confused about this change. it looks like dispatching an event to
the tame window will also dispatch it to the tame document? that isn't
what browsers do.
would it be simpler to wrap everything in an actual <caja-v-window> or
<caja-v-defaultView> element?
https://codereview.appspot.com/11128043/diff/1/src/com/google/caja/plugin/domado.js
File src/com/google/caja/plugin/domado.js (right):
https://codereview.appspot.com/11128043/diff/1/src/com/google/caja/plugin/domado.js#newcode3493
src/com/google/caja/plugin/domado.js:3493: var i; // closed over!
er, yeah. it took a couple minutes to figure out why that matters. I'd
be happier if that remove() function were a literal within the loop
https://codereview.appspot.com/11128043/diff/1/src/com/google/caja/plugin/domado.js#newcode3495
src/com/google/caja/plugin/domado.js:3495: var record = typeTable[+i];
why the + ?
https://codereview.appspot.com/11128043/diff/1/src/com/google/caja/plugin/domado.js#newcode3553
src/com/google/caja/plugin/domado.js:3553: match.add(remove);
match.add(remove) reads weirdly. the effect is not at all what I'd
expect if I saw this line of code anywhere else. it's more like
notMatched.addSelfToTableThatDidntFindMeAlongWith(removeHook), but I
haven't thought of a more concise way to say what it means.
maybe change the api to be: table.add(match, removeHook)?
https://codereview.appspot.com/11128043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
