On 2013/07/10 21:32:52, felix8a wrote:
I'm confused about this change. it looks like dispatching an event to
the tame
window will also dispatch it to the tame document? that isn't what
browsers do.
Er, no? TameWindow.prototype.dispatchEvent dispatches via
windowSplitTarget only. Events dispatched on TameDocument will be seen
at TameWindow, but that _is_ what browsers do.
would it be simpler to wrap everything in an actual <caja-v-window> or
<caja-v-defaultView> element?
Yes, but doing exactly that would be incompatible with the planned
iframe-document-as-container feature. However, what we could do in that
case is use the feral window itself as the extra container to put
listeners on (and in the current world, we can just use the outer level
of the double-div — that just means letting Domado know about it).
I initially avoided this because I didn't want to make Domado care about
the outer container, but after having written this version, I can see
that that might be worth doing instead. It would eliminate the need for
both SplitEventTarget and for extracting EventListenerTable.
So, given that we're not in a hurry about this, I'll write that
implementation and see whether we like it.
https://codereview.appspot.com/11128043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
