Also added some minor fixes to WeakMap.js and
atLeastFreeVariableNames.js to address complaints from the linker.
Please have a look. I won't submit until we understand the StringMap
problem. Any suspicions about what it might be?
https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/StringMap.js
File src/com/google/caja/ses/StringMap.js (right):
https://codereview.appspot.com/10075043/diff/86001/src/com/google/caja/ses/StringMap.js#newcode20
src/com/google/caja/ses/StringMap.js:20: * @overrides ses
On 2013/07/09 16:34:59, kpreid2 wrote:
Instead of @overrides (I assume this is needed because of the var
declaration?),
how about replacing the || {} chain with
if (typeof ses !== 'undefined' &&
ses.es5ProblemReports.FREEZING_BREAKS_PROTOTYPES.beforeFailure)
This will fail if the intermediate objects are missing, but that is an
appropriate inconsistency-failure to catch.
Doing as suggested (patch 14) broke runtests, apparently detecting the
kind of inconsistency you raised. With patch 15, which chains tests
analogously to the original, runtests completes successfully. Not sure
why yet.
https://codereview.appspot.com/10075043/
--
---
You received this message because you are subscribed to the Google Groups "Google Caja Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
